Skip to content

fix: normalize idl doc comments#1277

Merged
m62624 merged 3 commits intomasterfrom
fix/idl-doc-comments
Apr 6, 2026
Merged

fix: normalize idl doc comments#1277
m62624 merged 3 commits intomasterfrom
fix/idl-doc-comments

Conversation

@m62624
Copy link
Copy Markdown
Member

@m62624 m62624 commented Apr 3, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IDL parser to handle documentation comments by stripping prefixes and trimming whitespace, and adds a corresponding test case. Feedback includes correcting the test expectation to account for blank documentation lines and removing redundant string manipulation logic that is already handled by the parser rules.

Comment thread rs/idl-parser-v2/src/lib.rs
Comment thread rs/idl-parser-v2/src/lib.rs Outdated
Comment thread rs/idl-parser-v2/src/lib.rs
Comment thread rs/idl-parser-v2/src/idl.pest Outdated
@m62624 m62624 requested a review from vobradovich April 6, 2026 05:59
@m62624 m62624 merged commit 167fff5 into master Apr 6, 2026
4 checks passed
@m62624 m62624 deleted the fix/idl-doc-comments branch April 6, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants