Add simple terraform pipeline eval#140
Merged
haroonc merged 2 commits intogemini-cli-extensions:evalsfrom Apr 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dynamic resource naming for evaluation tasks, updates cleanup and validation scripts to handle these names as arguments, and adds a new evaluation task for designing CI/CD pipelines using Terraform. Feedback highlights potential issues in the new validation scripts, specifically regarding the fragility of using grep for YAML and Terraform plan analysis, the lack of variable handling in Terraform validation, and the removal of explicit project flags in GCS cleanup which could lead to environment-dependent failures.
haroonc
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple eval for testing the pipeline design skill when the user asks for Terraform and Cloud Deploy to be used.
Static assertions check for a cloudbuild.yaml file with test, build, push and deploy steps and a check that the created terraform is valid, and contains resources that are expected for this type of deployment. We may want to improve these checks in the future.
Note that this eval is quite flaky, as often the expected skills are not triggered. We can use this to drive improvements to the skill definitions so that they are applied more consistently.