add new tool for cloud run

[aliciatang07]

cloudrun.service_status: Provide detailed status of a Cloud Run services and logs from the service.

[aliciatang07]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new tool for checking the status of a Cloud Run service. However, the current implementation contains several critical issues, including compilation errors due to incorrect function signatures and type mismatches, a malformed JSON struct tag, and an incomplete tool registration function that would prevent the new tool from working at all. I have provided detailed comments and code suggestions to address these problems and ensure the new functionality is correctly implemented.

[gemini-code-assist]

This new function to add the service status tool is incomplete and has several issues that will cause compilation and runtime errors:

1. Function Name Mismatch: The function is named addGetServiceStatusTool, but it's called as addGetServiceStatus in the Register method. This will cause an "undefined" compile error.
2. Missing Tool Registration: The function defines a tool handler (getServiceStatusToolFunc) but never registers it with the MCP server using mcp.AddTool. The tool will not be available.
3. Incorrect Handler Signature: The function literal for the handler is missing its return types (*mcp.CallToolResult, any, error). This is a compile error.
4. Undeclared Variable: The variable getServiceStatusToolFunc is used without being declared at the package level. You need to add a var declaration for it, similar to listServicesToolFunc.
5. Formatting Issues: There are several formatting problems, including incorrect indentation and a missing space in req* mcp.CallToolRequest.

Here is a corrected version of the function. Please note you will also need to add var getServiceStatusToolFunc func(ctx context.Context, req *mcp.CallToolRequest, args GetServiceStatusArgs) (*mcp.CallToolResult, any, error) at the package level.

Suggested change

	func addGetServiceStatusTool(server *mcp.Server, crClient cloudrunclient.CloudRunClient) {
	getServiceStatusToolFunc = func(ctx context.Context, req* mcp.CallToolRequest, args GetServiceStatusArgs){
	state, err := crClient.GetServiceStatus(ctx, args.ProjectID, args.Location, args.ServiceName)
	if err != nil {
	return &mcp.CallToolResult{}, nil, fmt.Errorf("failed to get service state: %w", err)
	}
	return &mcp.CallToolResult{}, state, nil
	}
	}
	func addGetServiceStatus(server *mcp.Server, crClient cloudrunclient.CloudRunClient) {
	getServiceStatusToolFunc = func(ctx context.Context, req *mcp.CallToolRequest, args GetServiceStatusArgs) (*mcp.CallToolResult, any, error) {
	state, err := crClient.GetStatus(ctx, args.ProjectID, args.Location, args.ServiceName)
	if err != nil {
	return &mcp.CallToolResult{}, nil, fmt.Errorf("failed to get service state: %w", err)
	}
	return &mcp.CallToolResult{}, state, nil
	}
	mcp.AddTool(server, &mcp.Tool{Name: "cloudrun.service_status", Description: "Provide detailed status of a Cloud Run service."}, getServiceStatusToolFunc)
	}

[aliciatang07]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new tool, cloudrun.service_status, to fetch the status of a Cloud Run service. The implementation is straightforward, but I've identified a critical issue that could lead to a panic due to a potential nil pointer dereference. I've also pointed out a code formatting issue. Additionally, the new functionality lacks corresponding unit tests. Please add tests for the GetServiceStatus tool to ensure its correctness and prevent future regressions.