Merged
Conversation
The v1 endpoint /v1/name/resolve/ returns 404 for all requests. Migrate to /v2/devices/name/resolve/ (matching iOS) which uses authenticated device API via SecurityInterceptor.
- Add ResolveNameCase interface in gemcore/cases/name/ - Add NameRepository implementation in data:repositories/name/ - Add NameModule Hilt DI in data:repositories/di/ - Remove duplicate AddressChainViewModel from add_asset:viewmodels - Update single AddressChainViewModel in recipient:viewmodels to use ResolveNameCase instead of direct API client dependency - Update add_asset:presents and import_wallet to use the shared ViewModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to /v2/devices/name/resolve/ (matching iOS) which uses authenticated device API via SecurityInterceptor.