Skip to content

fix: shellcheck errors in start.sh; add code-quality CI workflow#15

Merged
jonryser merged 1 commit intomainfrom
fix/shellcheck-and-ci-workflow
Mar 18, 2026
Merged

fix: shellcheck errors in start.sh; add code-quality CI workflow#15
jonryser merged 1 commit intomainfrom
fix/shellcheck-and-ci-workflow

Conversation

@genui-scotty
Copy link

@genui-scotty genui-scotty bot commented Mar 18, 2026

Summary

🐛 start.sh — ShellCheck fixes

  • SC2004 (line 94): removed unnecessary $ on arithmetic variable — $charwidthcharwidth
  • SC1083 (line 123): quoted curl format string — %{http_code}'%{http_code}'
  • SC2154 (line 143): fixed typo — ${chars:$iterator:1}${char:$iterator:1} (variable chars was never defined; char was)

.github/workflows/code-quality.yml

Adds a CI workflow that runs on PRs to main, following the GenUI pattern:

  • Detects changed markdown and shell files via tj-actions/changed-files@v47
  • Lints markdown with DavidAnson/markdownlint-cli2-action@v22
  • Lints shell scripts with reviewdog/action-shellcheck@v1
  • Short-circuits cleanly when no relevant files changed

📄 .github/workflows/CODE_QUALITY.md

Documents the workflow — what runs, when, how to lint locally, and shellcheck suppressions.


Verified: shellcheck = 0 errors, markdownlint-cli2 = 0 errors before commit.

@jonryser jonryser force-pushed the fix/shellcheck-and-ci-workflow branch from e312427 to 7e73644 Compare March 18, 2026 01:24
@jonryser jonryser merged commit bc38434 into main Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant