Fix mobile hamburger menu on iOS Safari#6
Open
planetf1 wants to merge 9 commits intogenerative-computing:mainfrom
Open
Fix mobile hamburger menu on iOS Safari#6planetf1 wants to merge 9 commits intogenerative-computing:mainfrom
planetf1 wants to merge 9 commits intogenerative-computing:mainfrom
Conversation
Replace brittle CSS class selectors with semantic ARIA/role-based equivalents across all four E2E test files. Add minimal ARIA hooks to components to enable proper selectors: aria-label on mobile nav overlay, data-testid on contributor avatars, aria-label on blog post tags, and article elements for feature cards.
- Fix false-positive blog card selector on homepage (was matching nav link) - GitHub stats: check Stars/Forks labels in hero region instead of any link - Feature strip: verify unique content instead of CSS class count - Meta description: require 20+ chars instead of any non-empty string - Mobile hamburger close-on-link: assert overlay not visible after click - aria-expanded test: move to mobile spec where toggle is interactive - Blog post tags: conditional check — only assert when tags div is present - Sitemap: remove hardcoded blog slugs that break on content changes
Clicking 'Blog' caused navigation, making the not.toBeVisible() assertion trivially true on the destination page. Switch to clicking 'Docs' (target=_blank) which opens a new tab but keeps the test on the current page, so the assertion actually verifies the close handler fired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
position: stickyheader, which causesposition: fixeddescendants to be positioned relative to the sticky container rather than the viewport on iOS Safari (and all browsers per CSS spec) — resulting in a zero-height overlaycreatePortalto render it as a direct child of<body>, whereposition: fixedworks correctlyallowedDevOriginstonext.config.mjsfor local network testing during developmentTest plan
npm run build) succeeds with no errors