Conversation
7f6f10b to
d557f63
Compare
|
|
||
| # For GeoServer 3.0.0 tomcat:11.0-jdk21-temurin-noble required | ||
| ARG GEOSERVER_BASE_IMAGE=tomcat:9.0.116-jdk17-temurin-noble@sha256:8ffb46723346c5bc7d4a5f56b9ee9295da3fac216a6de31d1c8cf07a0c8efe59 | ||
| ARG GEOSERVER_BASE_IMAGE=tomcat:11.0-jdk21-temurin-noble |
There was a problem hiding this comment.
@buehner I think some of this is handled here:
Or is this PR changing the defaults, to be merged alongside 3.0 release?
There was a problem hiding this comment.
Yes. The main intention is to keep track of the defaults.
For a long time, I did not realize that the release script uses the GEOSERVER_BASE_IMAGE argument. That's why I - at that time - introduced the renovate bot to ensure that we always have an explicit, up-to-date version in the Dockerfile.
This brings me to another thought: As the release script uses a non-explicit "generic" version for the base image, this might lead to unwanted behavior: Docker internally caches tagged images once they were downloaded. Unless explicitly using flags like --pull, Docker would NOT pull new versions, even if they are available on a hub. And those images usually update often in the docker world, so we - at least in theory - miss security updates etc.
So I created this PR to adress this potential issue: #292
This is a branch for all the changes that are required to have the Dockerfile work with GeoServer 3.
It is WIP and should be merged, once GeoServer3 is officially released.
It is running fine with the current GeoServer3 Snapshot WAR file available. @jodygarnett I successfully tested all features of the docker image project (JNDI, CORS, GDAL, etc) and it is working fine! I could not find any issues.
Just try
docker-compose -f docker-compose-demo.yml up --build