Skip to content

#12044: Ability to setup scale limits for vector/WFS styling rules #12085

Merged
MV88 merged 4 commits intogeosolutions-it:masterfrom
mahmoudadel54:task_12044
Mar 20, 2026
Merged

#12044: Ability to setup scale limits for vector/WFS styling rules #12085
MV88 merged 4 commits intogeosolutions-it:masterfrom
mahmoudadel54:task_12044

Conversation

@mahmoudadel54
Copy link
Copy Markdown
Contributor

Description

This PR includes showing the scale denominator limits in style tab for vector/wfs layers and it handles also:

  • the functionality of scale limits layer filter for cesium/ol for wfs and vector layers
  • the functionality of scale limits layer filter in printing
  • the functionality of scale limits layer filter for leaflet for wfs and vector layers

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

#12044

What is the current behavior?

#12044

What is the new behavior?

User can define scale denominator limits for vector/wfs layers from style tab and it will be applied on map filter with zooming in/out if show/hide based on the scale limits.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

…tyling rules

- handle functionality of scale limits layer filter for cesium/ol for wfs and vector layers
- handle functionality of scale limits layer filter in print
- add unit tests
@mahmoudadel54 mahmoudadel54 added this to the 2026.01.01 milestone Mar 13, 2026
@mahmoudadel54 mahmoudadel54 requested a review from MV88 March 13, 2026 10:04
@mahmoudadel54 mahmoudadel54 self-assigned this Mar 13, 2026
@cla-bot cla-bot bot added the CLA Ready label Mar 13, 2026
@mahmoudadel54 mahmoudadel54 linked an issue Mar 13, 2026 that may be closed by this pull request
2 tasks
- revert a typo remove in PrintUtils
@tdipisa tdipisa assigned MV88 and unassigned mahmoudadel54 Mar 13, 2026
@MV88
Copy link
Copy Markdown
Contributor

MV88 commented Mar 20, 2026

@tdipisa i cannot properly test this locally due to this https://github.com/geosolutions-it/DevOps/issues/1773#issuecomment-4097104815

but it looks ok from codebase pov, let me know what do you think if you agree to proceed and test this on DEV

@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Mar 20, 2026
Copy link
Copy Markdown
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MV88 MV88 added backport 2026.01.xx and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Mar 20, 2026
@MV88 MV88 merged commit db1ad39 into geosolutions-it:master Mar 20, 2026
14 checks passed
@offtherailz
Copy link
Copy Markdown
Member

Successfully created backport PR for 2026.01.xx:

tdipisa pushed a commit that referenced this pull request Apr 10, 2026
…12085) (#12122)

* #12044: Ability to setup scale limits for vector/WFS styling rules
- handle functionality of scale limits layer filter for cesium/ol for wfs and vector layers
- handle functionality of scale limits layer filter in print
- add unit tests

* - handle functionality of scale limits layer filter for leaflet for wfs and vector layers

* - fix FE unit test failure

* - edits to fix FE failures
- revert a typo remove in PrintUtils

(cherry picked from commit db1ad39)

Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to setup scale limits for vector/WFS styling rules

3 participants