🐛 Fix smoke test path handling for direct function URLs#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deploy succeeded, but smoke tests failed when using direct Cloud Function URL output:
https://...cloudfunctions.net/progressThe smoke script appended
/progressagain, resulting in:.../progress/progress/76.Fix
In
scripts/smoke.sh, changed default expansion to only apply whenPROGRESS_PATHis unset (not when explicitly empty):${PROGRESS_PATH:-/progress}${PROGRESS_PATH-/progress}This preserves
PROGRESS_PATH=""from deploy workflow and supports both modes:/progressValidation
PROGRESS_PATH=""): ✅