Skip to content

Comments

🐛 Fix smoke test path handling for direct function URLs#18

Merged
gepser merged 1 commit intomasterfrom
feature/fix-smoke-path-default
Feb 22, 2026
Merged

🐛 Fix smoke test path handling for direct function URLs#18
gepser merged 1 commit intomasterfrom
feature/fix-smoke-path-default

Conversation

@gepser
Copy link
Owner

@gepser gepser commented Feb 22, 2026

Problem

Deploy succeeded, but smoke tests failed when using direct Cloud Function URL output:

https://...cloudfunctions.net/progress

The smoke script appended /progress again, resulting in:

.../progress/progress/76.

Fix

In scripts/smoke.sh, changed default expansion to only apply when PROGRESS_PATH is unset (not when explicitly empty):

  • from: ${PROGRESS_PATH:-/progress}
  • to: ${PROGRESS_PATH-/progress}

This preserves PROGRESS_PATH="" from deploy workflow and supports both modes:

  • domain root + default /progress
  • direct function URL + empty path

Validation

  • Local smoke with root base URL: ✅
  • Local smoke with direct function URL (PROGRESS_PATH=""): ✅

@gepser gepser merged commit 9809822 into master Feb 22, 2026
2 checks passed
@gepser gepser deleted the feature/fix-smoke-path-default branch February 22, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant