fix(native): build Linux binaries against GLIBC 2.28 for RHEL 8 compatibility#2351
Merged
dividedmind merged 1 commit intomainfrom Mar 4, 2026
Merged
fix(native): build Linux binaries against GLIBC 2.28 for RHEL 8 compatibility#2351dividedmind merged 1 commit intomainfrom
dividedmind merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the native-binary build pipeline so Linux artifacts are produced in a RHEL 8 (GLIBC 2.28) environment, improving compatibility with RHEL/Alma/Rocky 8 while also de-duplicating and generalizing the build-native packaging script across packages.
Changes:
- Add a RHEL 8 UBI + GCC Toolset 13 builder image and a CI job to build/push it to GHCR keyed by the Dockerfile hash.
- Run Linux native builds inside that container (and move linux-arm64 to
ubuntu-24.04-arm) to ensure addons are built against GLIBC 2.28. - Update
packages/cli/bin/build-nativeto derive output name frompackage.jsonand skippkgnative-addon rebuilds when targeting the current platform; replace scanner’s duplicate script with a link to the CLI version.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ci/Dockerfile.build |
Introduces the RHEL 8 builder image (Node 18 + GCC toolset 13) used for Linux native builds. |
.github/workflows/build-native.yml |
Adds the builder-image sync job and runs Linux builds inside the new container image. |
packages/cli/bin/build-native |
Generalizes output naming and adds logic to skip pkg native rebuilds for the current platform. |
packages/scanner/bin/build-native |
De-duplicates by pointing to the CLI build-native script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tibility Build linux-x64 and linux-arm64 inside a custom RHEL 8 UBI container (GCC Toolset 13) so that better_sqlite3.node is compiled against GLIBC 2.28 rather than the host runner's GLIBC 2.39, making the binaries compatible with RHEL 8 / AlmaLinux 8 / Rocky Linux 8. - ci/Dockerfile.build: new RHEL 8 UBI + GCC 13 builder image, cached in GHCR by Dockerfile SHA via the new sync-builder CI job - build-native.yml: linux jobs now run inside the builder container; linux-arm64 switches from self-hosted to ubuntu-24.04-arm - packages/cli/bin/build-native: pass --no-native-build when targeting the current platform (rely on yarn install's compiled addon instead of pkg fetching a pre-built one); derive output name from package.json so the script works for both appmap and scanner - packages/scanner/bin/build-native: replace duplicate script with a symlink to the cli version
6d44782 to
ce8d25d
Compare
hleb-rubanau
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build linux-x64 and linux-arm64 inside a custom RHEL 8 UBI container (GCC Toolset 13) so that better_sqlite3.node is compiled against GLIBC 2.28 rather than the host runner's GLIBC 2.39, making the binaries compatible with RHEL 8 / AlmaLinux 8 / Rocky Linux 8.