Skip to content

Fix SSRF vulnerability in webhook URLs#1494

Merged
mattwoberts merged 3 commits intogetfider:mainfrom
mattwoberts:webhook-local-access
Apr 12, 2026
Merged

Fix SSRF vulnerability in webhook URLs#1494
mattwoberts merged 3 commits intogetfider:mainfrom
mattwoberts:webhook-local-access

Conversation

@mattwoberts
Copy link
Copy Markdown
Contributor

Summary

  • Add WebhookURL() validator that blocks private IPs, loopback, link-local (cloud metadata), and non-http(s) schemes
  • Resolves hostnames via DNS to catch domains pointing to internal addresses
  • Applied at both webhook save time and trigger time (after template expansion)
  • Addresses GHSA-g445-xwm7-594r

Test plan

mattwoberts and others added 3 commits April 4, 2026 21:43
Webhook URLs were only validated for format, allowing admins to target
internal network addresses (localhost, private IPs, cloud metadata
endpoints). Add WebhookURL() validator that resolves hostnames and
blocks private/loopback/link-local IP ranges. Applied at both save
time and trigger time to cover template-expanded URLs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mattwoberts mattwoberts merged commit 92e5552 into getfider:main Apr 12, 2026
5 checks passed
@mattwoberts mattwoberts deleted the webhook-local-access branch April 12, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant