Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
d9da117 to
0396ee1
Compare
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/make.yaml">
<violation number="1" location=".github/workflows/make.yaml:216">
P1: Background process failures are silently ignored because `wait` with no arguments always returns 0. If any `go generate` command fails, the step will still succeed and subsequent `go build` steps will compile against missing/stale generated code.
Capture each PID and wait on them individually, or use `wait -n` in a loop, to propagate failures.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
4c43623 to
d81559b
Compare
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
There was a problem hiding this comment.
2 issues found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/codeql.yml">
<violation number="1">
P2: Pin GitHub Actions by commit SHA instead of mutable tags in this CodeQL workflow.</violation>
<violation number="2">
P1: Using `autobuild` for Go drops required codegen/embed preparation, which can break or reduce CodeQL analysis for Go.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -90,4 +90,4 @@ jobs: | |||
| - name: Perform CodeQL Analysis | |||
There was a problem hiding this comment.
P1: Using autobuild for Go drops required codegen/embed preparation, which can break or reduce CodeQL analysis for Go.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/codeql.yml, line 38:
<comment>Using `autobuild` for Go drops required codegen/embed preparation, which can break or reduce CodeQL analysis for Go.</comment>
<file context>
@@ -31,7 +35,7 @@ jobs:
build-mode: none
- language: go
- build-mode: manual
+ build-mode: autobuild
- language: javascript-typescript
build-mode: none
</file context>
| @@ -90,4 +90,4 @@ jobs: | |||
| - name: Perform CodeQL Analysis | |||
There was a problem hiding this comment.
P2: Pin GitHub Actions by commit SHA instead of mutable tags in this CodeQL workflow.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/codeql.yml, line 51:
<comment>Pin GitHub Actions by commit SHA instead of mutable tags in this CodeQL workflow.</comment>
<file context>
@@ -44,42 +48,46 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
+ uses: actions/checkout@v6
with:
submodules: recursive
</file context>
Summary by cubic
Rewrite CI/CD to use ephemeral GitHub-hosted runners with S3-backed cache and replace GoReleaser with first‑party GitHub Actions. Builds and releases are faster, signed, and automated across Docker, Homebrew, and npm.
runs-on=${{ github.run_id }}/runner=.../extras=s3-cacheviaruns-on/action@v2, pin actions by SHA, and tighten permissions across CI, CodeQL, secrets scan, and release; add./.github/actions/setupfor Go 1.26.1 and Node from.nvmrcwith caching.anchore/*.go generateand binary builds; splitlint-go/lint-js; faster e2e with Docker image caching and parallelstack-up; coverage viago tool cover.probod,probod-bootstrap, andprb; push per‑arch images, create andcosigna multi‑arch manifest; signchecksums.txt; generate notes withgh; publish GitHub Release, Homebrew formula forprbfrom release checksums, and@probo/n8n-nodes-proboto npm with SBOM/provenance attestations..goreleaser.yaml, drop old Make targets, addMAKEFLAGSfor parallelism, and useactions/upload-artifact@v7/actions/download-artifact@v8.Written for commit acf5913. Summary will update on new commits.