feat(taskworker): Attempt to add healthcheck logic#583
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Sentry Build Distribution
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
NicoHinderling
force-pushed
the
03-13-feat_taskworker_attempt_to_add_healthcheck_logic
branch
2 times, most recently
from
93739ca to
ff9dc65
Compare
NicoHinderling
force-pushed
the
03-12-feat_worker_add_taskworker_mode_for_taskbroker_rpc
branch
from
5b4d191 to
e7fae19
Compare
NicoHinderling
force-pushed
the
03-13-feat_taskworker_attempt_to_add_healthcheck_logic
branch
from
ff9dc65 to
8bb45d8
Compare
NicoHinderling
force-pushed
the
03-13-feat_taskworker_attempt_to_add_healthcheck_logic
branch
from
8bb45d8 to
4f1c4f6
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| gocd/templates/vendor/ | ||
| gocd/generated-pipelines/ | ||
|
|
||
| # uv |
There was a problem hiding this comment.
We don't want uv.lock here long term - I think we should be using uv.lock but can do this for now.
| logger = get_logger(__name__) | ||
|
|
||
|
|
||
| DEFAULT_HEALTH_CHECK_FILE_PATH = "/tmp/health" |
There was a problem hiding this comment.
Is there only one worker running per node?
Doing "launchpad-taskworker-{os.getpid()}" or something might be better
There was a problem hiding this comment.
supposedly the K8s liveness probe needs a static path baked into the pod spec. A PID-based path would break it. And since each pod has its own isolated /tmp, there's no collision risk anyway
| raise ValueError(f"LAUNCHPAD_WORKER_CONCURRENCY must be a valid integer, got: {concurrency_str}") | ||
|
|
||
| return WorkerConfig(rpc_hosts=rpc_hosts, concurrency=concurrency) | ||
| health_check_file_path = os.getenv("LAUNCHPAD_WORKER_HEALTH_CHECK_FILE_PATH", DEFAULT_HEALTH_CHECK_FILE_PATH) |
There was a problem hiding this comment.
Here also re maybe needing to include the pid/soem random number
NicoHinderling
deleted the
03-13-feat_taskworker_attempt_to_add_healthcheck_logic
branch
3 participants
No description provided.