test(service): Restructure bigtable tests into labelled sections#397
Merged
test(service): Restructure bigtable tests into labelled sections#397
Conversation
Reorganize 32 flat tests into 20 grouped tests across 5 sections. Merges paired happy/mismatch CAS tests, fills coverage gaps (put_non_tombstone scenarios, get_object TTI bump path, CAS-create object), and removes tests made redundant by the merged groups.
d47f193 to
41d8a66
Compare
…tone Use distinct hv_id and lt_id so the target assertion proves the `r` column serialises and deserialises correctly, rather than testing the degenerate case where target == hv_id (which passes even if the fallback path is taken by mistake). Also fixes a spurious trailing comma in test_tiered_get.
lcian
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the 32 flat Bigtable tests into 20 grouped tests across five labelled sections, merging paired and redundant tests and filling coverage gaps.
Backendtrait methods (put_object,get_object,get_metadata,delete_object), including TTI bump coverage for both theget_objectandget_metadatapathsHighVolumeBackendmethods (get_tiered_*,put_non_tombstone,delete_non_tombstone), each covering empty-row, object, and tombstone scenarioscompare_and_writevariants (create, swap-tombstone, swap-inline, create-object, delete), with happy-path and mismatch in a single test eachRef FS-309