Skip to content

test(service): Restructure bigtable tests into labelled sections#397

Merged
jan-auer merged 5 commits intomainfrom
test/restructure-bigtable-tests
Mar 20, 2026
Merged

test(service): Restructure bigtable tests into labelled sections#397
jan-auer merged 5 commits intomainfrom
test/restructure-bigtable-tests

Conversation

@jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 20, 2026

Reorganizes the 32 flat Bigtable tests into 20 grouped tests across five labelled sections, merging paired and redundant tests and filling coverage gaps.

  • Object Operations — core Backend trait methods (put_object, get_object, get_metadata, delete_object), including TTI bump coverage for both the get_object and get_metadata paths
  • Expiration — immediate-expiry smoke tests for TTL and TTI policies
  • Tiered Operations — HighVolumeBackend methods (get_tiered_*, put_non_tombstone, delete_non_tombstone), each covering empty-row, object, and tombstone scenarios
  • Compare-and-Write — all compare_and_write variants (create, swap-tombstone, swap-inline, create-object, delete), with happy-path and mismatch in a single test each
  • Legacy Tombstone Compatibility — read and conditional-write behaviour for legacy-format rows, TTI upgrade, and empty-redirect fallback

Ref FS-309

@jan-auer jan-auer requested a review from a team as a code owner March 20, 2026 08:17
@linear-code
Copy link

linear-code bot commented Mar 20, 2026

@jan-auer jan-auer marked this pull request as draft March 20, 2026 10:31
@jan-auer jan-auer changed the title test(service): Restructure bigtable.rs tests into labelled sections test(service): Restructure bigtable tests into labelled sections Mar 20, 2026
Base automatically changed from ref/atomic-tombstone-cas to main March 20, 2026 10:55
Reorganize 32 flat tests into 20 grouped tests across 5 sections.
Merges paired happy/mismatch CAS tests, fills coverage gaps (put_non_tombstone
scenarios, get_object TTI bump path, CAS-create object), and removes tests
made redundant by the merged groups.
@jan-auer jan-auer force-pushed the test/restructure-bigtable-tests branch from d47f193 to 41d8a66 Compare March 20, 2026 10:57
…tone

Use distinct hv_id and lt_id so the target assertion proves the `r`
column serialises and deserialises correctly, rather than testing the
degenerate case where target == hv_id (which passes even if the fallback
path is taken by mistake).

Also fixes a spurious trailing comma in test_tiered_get.
@jan-auer jan-auer marked this pull request as ready for review March 20, 2026 11:05
@jan-auer jan-auer merged commit b7ad0b9 into main Mar 20, 2026
20 checks passed
@jan-auer jan-auer deleted the test/restructure-bigtable-tests branch March 20, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants