fix(service): Replace ValueRange filters with regex in redirect matching#400
Merged
fix(service): Replace ValueRange filters with regex in redirect matching#400
Conversation
ValueRange with `EndValueClosed(vec![])` forms a degenerate empty range that silently mismatches. Replace all ValueRange filters in `redirect_target_filter` with `ValueRegexFilter`: exact paths use an anchored escaped regex, and the empty-redirect check uses `^$`. This also fixes a latent bug where storage path characters like `.` could match unintended values.
lcian
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueRange with
EndValueClosed(vec![])forms a wrong empty range that causes an an invalidValueRangeFilterin production BigTable. The emulator does not have this issue.exact_value_regexhelper — also fixes a latent bug where.and/in storage paths could match unintended byte values^$regex instead of the broken empty rangeRef FS-309