fix(minidump): Enforce max_attachment_size during decompression#5613
Merged
fix(minidump): Enforce max_attachment_size during decompression#5613
Conversation
jjbayer
commented
Feb 24, 2026
|
|
||
| // With a limit smaller than the decompressed size, decoding should fail with Overflow | ||
| let result = decode_minidump(compressed, 50); | ||
| assert!(matches!(result, Err(BadStoreRequest::Overflow(_)))); |
Member
Author
There was a problem hiding this comment.
This assertion fails without the new logic.
Stop decoding compressed minidumps when the decompressed size exceeds max_attachment_size, preventing decompression bombs from exhausting memory. This applies the same limit that Content-Encoding decompression uses. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
jjbayer
force-pushed
the
fix/minidump-decompression-size-limit
branch
from
8458738 to
74458a4
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Dav1dde
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a minidump comes with
Content-Encoding, we stop decompressing when we hit the size limit. However, if a multipart field contains a compressed minidump, we decompress the full item and only remove it later incheck_envelope_size_limits. This causes unnecessary memory usage.