feat(develop/spans): Add Span Buffer specification#16327
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
overall looks reasonable, however what is the long-term plan for the span buffer page? I'd imagine that it will easily gets out of sync with the telemetry processor docs and since both kinda have the same info it could be confusing which one is the source of truth for spans
|
The work on the telemetry processor is on hold. So having all things spans under one menu item is ok imo. |
My take for now: If SDKs already implement(ed) the telemetry processor (not sure if any), the span buffer specification is more or less in there, so I'd recommend they stick with that. For SDKs having not done this yet (which I assume is the majority), the new span buffer page should be all they care about at the moment for span streaming. Does this sound reasonable? |
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Looks great, thanks for adding!
5 participants
As discussed yesterday, this PR adds a spec for a span buffer. This is less specified than the Telemetry Processor but more formal than the recommendation in the Span-First implementation guide (which I removed in favor of this page).
Most important change: We added weight-based flushing as an addition to the previous flushing behaviour
closes https://linear.app/getsentry/issue/FE-718/span-buffer-section-in-dev-docs