-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore(deps): migrate to ESLint 9 with flat config #17108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfanahata
wants to merge
1
commit into
master
Choose a base branch
from
chore/eslint-9-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,669
−1,421
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| const {FlatCompat} = require('@eslint/eslintrc'); | ||
| const js = require('@eslint/js'); | ||
| const nextPlugin = require('@next/eslint-plugin-next'); | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| recommendedConfig: js.configs.recommended, | ||
| allConfig: js.configs.all, | ||
| }); | ||
|
|
||
| module.exports = [ | ||
| // Global ignores | ||
| { | ||
| ignores: [ | ||
| '.babelrc.js', | ||
| '.next/**', | ||
| 'node_modules/**', | ||
| 'out/**', | ||
| 'public/**', | ||
| ], | ||
| }, | ||
|
|
||
| // Use FlatCompat for eslint-config-sentry-docs (still in eslintrc format) | ||
| ...compat.extends('sentry-docs'), | ||
|
|
||
| // Next.js plugin rules (use plugin directly to avoid conflicts with sentry-docs config) | ||
| { | ||
| plugins: { | ||
| '@next/next': nextPlugin, | ||
| }, | ||
| rules: { | ||
| ...nextPlugin.configs.recommended.rules, | ||
| }, | ||
| }, | ||
|
|
||
| // Main configuration and rule overrides | ||
| { | ||
| languageOptions: { | ||
| globals: { | ||
| Atomics: 'readonly', | ||
| SharedArrayBuffer: 'readonly', | ||
| }, | ||
| }, | ||
| rules: { | ||
| 'import/no-nodejs-modules': 'off', | ||
|
|
||
| // Disable deprecated @typescript-eslint rules from eslint-config-sentry-docs | ||
| // These were removed/renamed in @typescript-eslint v8 | ||
| '@typescript-eslint/ban-types': 'off', | ||
| '@typescript-eslint/no-empty-interface': 'off', | ||
|
|
||
| // Enable the replacement rules for ban-types | ||
| // Allow empty interfaces that extend other types (used for recursive type definitions) | ||
| '@typescript-eslint/no-empty-object-type': ['error', {allowInterfaces: 'with-single-extends'}], | ||
| '@typescript-eslint/no-unsafe-function-type': 'error', | ||
| '@typescript-eslint/no-wrapper-object-types': 'error', | ||
|
|
||
| // Disable rules from plugins that aren't compatible with ESLint 9 | ||
| // eslint-plugin-no-lookahead-lookbehind-regexp@0.3.0 has incompatible schema | ||
| 'no-lookahead-lookbehind-regexp/no-lookahead-lookbehind-regexp': 'off', | ||
| }, | ||
| }, | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transitive dependency required directly may break under strict resolution
Medium Severity
eslint.config.jsdirectlyrequires@next/eslint-plugin-next, but this package is not a directdevDependency— it's only installed transitively througheslint-config-next. Meanwhile,eslint-config-nextitself is no longer referenced anywhere in the ESLint config (the old.eslintrc.jsusedplugin:@next/next/recommended; the new config usesnextPlugindirectly). This creates a fragile setup: if someone removes the seemingly-unusedeslint-config-nextfrompackage.json,eslint.config.jswill fail atrequiretime. Theglobalspackage is similarly an unused direct dependency. Adding@next/eslint-plugin-nextas a directdevDependencyand removingeslint-config-nextandglobalswould clarify the actual dependency graph.Additional Locations (1)
package.json#L150-L151