fix(ci): Prevent command injection in ci-metadata workflow#19899
Open
fix-it-felix-sentry[bot] wants to merge 1 commit intodevelopfrom
Open
fix(ci): Prevent command injection in ci-metadata workflow#19899fix-it-felix-sentry[bot] wants to merge 1 commit intodevelopfrom
fix-it-felix-sentry[bot] wants to merge 1 commit intodevelopfrom
Conversation
Move GitHub context interpolation into an environment variable to prevent potential command injection attacks. The github.event.pull_request.head.sha and other GitHub context data can contain arbitrary user input and should not be directly interpolated into shell scripts. References: - Parent ticket: https://linear.app/getsentry/issue/VULN-1328 - Child ticket: https://linear.app/getsentry/issue/JS-1972 - https://docs.github.com/en/actions/learn-github-actions/security-hardening-for-github-actions#understanding-the-risk-of-script-injections Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity security vulnerability where GitHub context data was being directly interpolated into a shell script, potentially allowing command injection attacks.
Changes
github.event.pull_request.head.shaand related GitHub context expressions into an environment variableCOMMIT_SHA_EXPR"$COMMIT_SHA_EXPR")Security Impact
Before this fix, an attacker could potentially inject malicious code through pull request metadata, which would be executed in the GitHub Actions runner with access to secrets and code.
After this fix, the GitHub context data is safely passed through an environment variable, preventing command injection.
References