feat(crashpad): offline caching#1493

Merged

jpnurmi merged 54 commits intomasterfrom

jpnurmi/feat/crashpad-offline-caching

Feb 11, 2026

Collaborator

jpnurmi commented Jan 26, 2026 •

edited

Loading

Converts completed Crashpad reports to Sentry envelopes for offline caching.

After N upload/retry attempts, Crashpad moves reports to <db>/completed/
On the next SDK init, the Crashpad backend iterates over completed reports
- Each report is converted into a Sentry envelope stored in <db>/cache/
Cache pruning is applied as usual

Depends on:

See also:

Support Offline Caching of Envelopes #1316

JoshuaMoelans and others added 16 commits

January 23, 2026 14:21


          Import offline caching POC (#1461)

536c4a1

Before "revert separate caching folder implementation"

#1461


          breakpad: delete .dmp

5742eda


          Flatten cache/

6c75ccf


          Add tests

8f3ffd5


          Respect has_breakpad

3410b6c


          SENTRY_TRANSPORT=none

799d219


          Fix set_file_mtime on Windows

3c40494


          Present cache_max_age in seconds

a37ac86


          Present max_cache_size in bytes

20815bd


          Tweak docs & signatures

ef96547


          Fix warning

e96d9d4


          Fix test_unit::cache_max_age

93aefb2


          Fix sign conversion warning on Windows

f4936d5

Cast cache_max_age to time_t to avoid implicit signedness conversion
between uint64_t and time_t.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Add changelog entry for offline caching feature

7eddee4

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Fix sign conversion warning in CleanDatabase call

8d40ec1

Add explicit static_cast<time_t>() for cache_max_age to fix
-Wsign-conversion warning on Windows with clang-cl.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Clarify test_integration_cache

b28663f

This was referenced Jan 26, 2026

feat: add sentry__value_from_msgpack #1492

Merged

ref: expose merge_breadcrumbs for crashpad offline caching #1491

Merged

jpnurmi force-pushed the jpnurmi/feat/crashpad-offline-caching branch 4 times, most recently from 4dd6c5e to ff864c4 Compare

January 26, 2026 15:27

jpnurmi and others added 3 commits

January 27, 2026 13:57


          Change cache_max_age type from uint64_t to time_t

ab62f90

For consistency with time-related operations throughout the codebase.

This adds a time.h dependency to the public header, but it's a
lightweight standard C header available since C89.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Merge remote-tracking branch 'upstream/master' into jpnurmi/feat/offl…

7bc7856

…ine-caching


          Update CHANGELOG.md

9e09bd0

jpnurmi mentioned this pull request

feat: offline caching (inproc & breakpad) #1490

Merged

2 tasks

jpnurmi and others added 4 commits

February 3, 2026 12:16


          Log warning when envelope caching fails

747edb1

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Revise crashpad_backend_prune_database

b1a4671


          Fix cache size calculation to exclude pruned files

b101fce

Subtract file size from accumulated_size when a file is pruned (by age
or size). Previously, pruned files' sizes were still counted, causing
subsequent valid files to be incorrectly pruned when both cache_max_age
and cache_max_size were set.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>


          Add NULL checks after path allocations in cache handling

2e1c63b

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

jpnurmi changed the title ~~WIP: feat(crashpad): offline caching~~ feat(crashpad): offline caching

github-actions bot commented Feb 10, 2026 •

edited

Loading

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2985e08

jpnurmi marked this pull request as ready for review

February 10, 2026 09:32


          fix changelog

74713f6

cursor bot reviewed

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

src/backends/sentry_backend_crashpad.cpp Outdated Show resolved Hide resolved

jpnurmi and others added 2 commits

February 10, 2026 11:53


          fix(crashpad): missing DSN header in cached envelopes

bd2bafe

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          fix(crashpad): check return value of sentry__envelope_add_event

f5e6a7a

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry bot reviewed

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

jpnurmi and others added 2 commits

February 10, 2026 12:09


          refactor(crashpad): inline report_minidump_path

0c291b1

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          fix(crashpad): skip caching already cached reports

30e3320

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sentry bot reviewed

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Outdated Show resolved Hide resolved

cursor bot reviewed

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

jpnurmi and others added 3 commits

February 10, 2026 12:26


          fix(crashpad): decref event when sentry__envelope_add_event fails

8a22d2c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          fix(crashpad): delete completed report when cache file already exists

7c72f1c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>


          docs(crashpad): add comments to report_to_envelope and process_comple…

97b2723

…ted_reports

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jpnurmi requested review from JoshuaMoelans and mujacica

February 10, 2026 12:39

mujacica approved these changes

View reviewed changes

Base automatically changed from jpnurmi/feat/offline-caching to master

February 11, 2026 13:13


          Merge branch 'master' into jpnurmi/feat/crashpad-offline-caching

709d7f2

sentry bot reviewed

View reviewed changes

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

jpnurmi mentioned this pull request

fix: prevent double-decref of event in envelope add functions #1511

Merged

jpnurmi closed this in #1511

jpnurmi reopened this


          Merge remote-tracking branch 'upstream/master' into jpnurmi/feat/cras…

2985e08

…hpad-offline-caching

cursor bot reviewed

View reviewed changes

cursor bot left a comment

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

src/backends/sentry_backend_crashpad.cpp

+                      } else if (state->db->DeleteReport(report.uuid)
+                          != crashpad::CrashReportDatabase::kNoError) {
+                          SENTRY_WARNF("failed to delete \"%s\"", filename.c_str());
+                      }

cursor bot Feb 11, 2026

Partial cache file causes report deletion and data loss

Medium Severity

If sentry_envelope_write_to_path fails but leaves a partial/corrupt file on disk, the next startup will see sentry__path_is_file(out_path) return true, skip rewriting the envelope, and proceed to call DeleteReport — permanently deleting the Crashpad report while only a corrupt envelope remains in cache. The sentry__path_is_file check doesn't validate the file's integrity, so a half-written file from a previous failed attempt is treated as a successfully cached envelope.

Collaborator Author

jpnurmi Feb 11, 2026 •

edited

Loading

Not sure... To validate the file's integrity, we would either have to store the checksum somewhere or parse the previously written envelope. 🤔

The lack of atomic (temp+rename) file writes could bite in several places in sentry-native. Another scenario: crash during envelope write -> truncated .envelope on disk -> next sentry_init() calls sentry__process_old_runs() -> sentry__envelope_from_path() reads truncated buffer as raw payload -> corrupted envelope sent to Sentry.

src/backends/sentry_backend_crashpad.cpp Show resolved Hide resolved

jpnurmi merged commit 9e8a954 into master

46 checks passed

jpnurmi deleted the jpnurmi/feat/crashpad-offline-caching branch

February 11, 2026 18:01

BrewTestBot mentioned this pull request

sentry-native 0.12.7 Homebrew/homebrew-core#267191

Merged

1 task

tustanivsky mentioned this pull request

chore(tests): skip tests relying on unsupported APIs on NX and PS platforms #1517

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet