fix(strawberry): Prevent AttributeError on missing graphql_span (#4991)#5731
Open
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Open
fix(strawberry): Prevent AttributeError on missing graphql_span (#4991)#5731harryautomazione wants to merge 1 commit intogetsentry:masterfrom
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Strawberry integration (
SentryAsyncExtension/SentrySyncExtension), hooks likeresolve(),on_parse(), andon_validate()accessself.graphql_spanwith the assumption that.on_operation()had already initialized it.Under some configurations (e.g., cached execution, isolated field-runs, or custom execution paths),
.on_operation()might be bypassed, leading toAttributeError: ... has no attribute 'graphql_span'.Solution
Added defensive
getattr(self, "graphql_span", None)checks in those hooks to safely bypass child span creation if the root span was not created. This preserves operation execution and output correctly without crashing the application.Fixes #4991