fix(asyncio): Add task_isolation setting for AsyncioIntegration (#5371)#5734
Open
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Open
fix(asyncio): Add task_isolation setting for AsyncioIntegration (#5371)#5734harryautomazione wants to merge 1 commit intogetsentry:masterfrom
harryautomazione wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Anthropic
Other
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
AsyncioIntegrationwraps every asyncio task in a newisolation_scope(). While this is great for isolating background tasks, it prevents scope data (like tags set viasentry_sdk.set_tag()) inside async endpoints from propagating back to the parent middleware transaction (e.g. in FastAPI/Starlette).Solution
This PR adds a
task_isolation: boolparameter (defaultTrue) toAsyncioIntegration.Setting
task_isolation=Falsedisables the automaticisolation_scope()for tasks, allowing tags written inside endpoints to correctly attach to the outer HTTP transaction trace.Fixes #5371
Verification
Verified with a reproduction script that with
task_isolation=False, tags set inside local endpoint asyncio tasks correctly surface on the captured HTTP response transaction.