-
-
Notifications
You must be signed in to change notification settings - Fork 360
chore(deps): update Sentry Android Gradle Plugin to v6.4.0 #5974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ export interface SentryAndroidGradlePluginOptions { | |
| includeSourceContext?: boolean; | ||
| } | ||
|
|
||
| export const sentryAndroidGradlePluginVersion = '6.3.0'; | ||
| export const sentryAndroidGradlePluginVersion = '6.4.0'; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: A version mismatch between the Android Gradle Plugin's bundled SDK (8.38.0) and the declared dependency (8.37.1) will cause a fatal Suggested FixUpdate the Prompt for AI AgentDid we get this right? 👍 / 👎 to inform future reviews. |
||
|
|
||
| /** | ||
| * Adds the Sentry Android Gradle Plugin to the project. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AGP 6.4.0 bundles SDK 8.38.0 but repo pins 8.37.1
High Severity
Per the PR changelog, AGP 6.4.0 bumps its bundled
sentry-androidSDK from 8.37.1 to 8.38.0. However,packages/core/android/build.gradlestill explicitly declaresapi 'io.sentry:sentry-android:8.37.1'anddebugImplementation 'io.sentry:sentry-spotlight:8.37.1', andpackages/core/android/expo-handler/build.gradlestill declarescompileOnly 'io.sentry:sentry-android:8.37.1'. This introduces a version mismatch that didn't exist with AGP 6.3.0. The repo's owncheck-android-sdk-mismatch.jsCI check is designed to catch and fail on exactly this scenario due to the risk ofIllegalStateException: Sentry SDK has detected a mix of versions. Flagged per the dependency update review rule (project-0b61c077c0c2).Additional Locations (1)
samples/react-native/android/build.gradle#L18-L19Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 8aea7fd. Configure here.