Skip to content

perf: Optimize lowercase check in RequestInterface #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sl0thentr0py merged 1 commit into from
Mar 19, 2026
Merged

perf: Optimize lowercase check in RequestInterface #2908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sentry-ruby/lib/sentry/interfaces/request.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ def filter_and_format_headers(env, send_default_pii)
end
end

# Regex to detect lowercase chars — match? is allocation-free (no MatchData/String)
LOWERCASE_PATTERN = /[a-z]/.freeze

def is_skippable_header?(key)
key.upcase != key || # lower-case envs aren't real http headers
key.match?(LOWERCASE_PATTERN) || # lower-case envs aren't real http headers
key == "HTTP_COOKIE" || # Cookies don't go here, they go somewhere else
!(key.start_with?("HTTP_") || CONTENT_HEADERS.include?(key))
end
Expand Down
Loading