ci(release): Switch from action-prepare-release to Craft#955
ci(release): Switch from action-prepare-release to Craft#955
Conversation
This PR migrates from the deprecated action-prepare-release to the new Craft GitHub Actions (reusable workflow or composite action). Changes: - Migrate .github/workflows/release.yml to Craft reusable workflow
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Build / dependencies / internal 🔧
🤖 This preview updates automatically when you update the PR. |
The previous migration incorrectly removed the GitHub App token authentication step. This commit restores it by switching to the composite action pattern which preserves the auth flow.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
I left some comments.
Also, just wondering, what exactly is the practical difference between this new action and the previous one?
|
@szokeasaurusrex - major thing is this new action now lives in the Craft repo, making it follow the changes in Craft. With the other one, 2 separate repos, it was a challeng to keep them in sync as the action directly relies on specific Craft functionality. There are also more things you can read at https://vanguard.getsentry.net/p/cmjq5p94l0000op3ekl5qf10e (or newer Craft changelogs) |
|
Lint failures are unrelated to the current changes; most likely a new Rust release. I'll fix it |
2 participants
Summary
This PR migrates from the deprecated
action-prepare-releaseto the new Craft GitHub Actions.Changes
.github/workflows/release.ymlto Craft reusable workflowDocumentation
See https://getsentry.github.io/craft/github-actions/ for more information.