Skip to content

build: cargo update#968

Open
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/bump-msrvfrom
szokeasaurusrex/update-cargo
Open

build: cargo update#968
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/bump-msrvfrom
szokeasaurusrex/update-cargo

Conversation

@szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Feb 2, 2026

Run cargo update to bump all dependencies to the latest versions.

Stacked on #970.

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) February 2, 2026 15:03
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but looks like it breaks MSRV as crates may not consider MSRV for breaking changes.

@szokeasaurusrex
Copy link
Member Author

@Dav1dde, indeed; I believe we will need to bump MSRV. I'm also thinking we may wish to define a clearer MSRV policy in the SDK; as I understand it, most crates do not consider MSRV bumps to be semver-breaking changes, so we should adopt an explicit policy as to which versions we aim to support

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/update-cargo branch from 0cb5f31 to fb9917f Compare February 3, 2026 13:34
@szokeasaurusrex szokeasaurusrex changed the base branch from master to szokeasaurusrex/bump-msrv February 3, 2026 13:34
@szokeasaurusrex
Copy link
Member Author

szokeasaurusrex commented Feb 3, 2026

@Dav1dde, I have bumped MSRV to 1.88 in #970, and stacked this PR on top. MSRV tests appear to be passing.

@Dav1dde
Copy link
Member

Dav1dde commented Feb 3, 2026

@lcian's suggestion with changing the resolver is an interesting idea, because overall you're not actually changing the practical MSRV (since there still is a configuration of dependencies which satisfies the original MSRV), just CI which we use fails with the dependencies specified in this lock file.

Changing MSRV overall is also fine, I would still be careful to not bump individual dependency ranges (e.g. from 1.1 to 1.9), if not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants