build: cargo update#968
Conversation
Dav1dde
left a comment
There was a problem hiding this comment.
Makes sense, but looks like it breaks MSRV as crates may not consider MSRV for breaking changes.
|
@Dav1dde, indeed; I believe we will need to bump MSRV. I'm also thinking we may wish to define a clearer MSRV policy in the SDK; as I understand it, most crates do not consider MSRV bumps to be semver-breaking changes, so we should adopt an explicit policy as to which versions we aim to support |
0cb5f31 to
fb9917f
Compare
|
@lcian's suggestion with changing the resolver is an interesting idea, because overall you're not actually changing the practical MSRV (since there still is a configuration of dependencies which satisfies the original MSRV), just CI which we use fails with the dependencies specified in this lock file. Changing MSRV overall is also fine, I would still be careful to not bump individual dependency ranges (e.g. from |
Run
cargo updateto bump all dependencies to the latest versions.Stacked on #970.