ref(cargo): Extract common items to workspace#969
ref(cargo): Extract common items to workspace#969szokeasaurusrex wants to merge 1 commit intomasterfrom
Conversation
c203754 to
40651f8
Compare
|
I assume it will also not accept the shorthand: There is an issue in the Not familiar overall with the release process etc, but your suggestion also makes sense to me. |
imho it would be simplest just to keep the |
I will double-check this |
Totally fair! |
Extract all common package items, which can be extracted, to the workspace
Cargo.toml, except for theversionfield.Note on
versionWe cannot extract
versionbecause it causes a parse error when generating the crateREADME.mdfiles while bumping the version prior to release, as thecargo-readmetool we use to generate these files apparently cannot parseversion = { workspace = true }, as it expects version to be set to a string.@Dav1dde, do you have any suggestions for how to get around this? I think the way forward may be to simply stop using
cargo readme, as our README files are quite verbose. Instead, I would propose having a short static README for each crate, directing users interested in full docs over to our docs.rs pages. What do you think?In any case, this should happen in a separate PR.