feat(sentry-types): Add Envelope::into_items method#983
Draft
szokeasaurusrex wants to merge 1 commit intomasterfrom
Draft
feat(sentry-types): Add Envelope::into_items method#983szokeasaurusrex wants to merge 1 commit intomasterfrom
Envelope::into_items method#983szokeasaurusrex wants to merge 1 commit intomasterfrom
Conversation
|
Add a new method called `into_items` to the `Envelope` type. This method is similar to the existing `items` method, except that it yields owned `EnvelopeItem`s rather than references. Also, refactor a test where we can use this new method to avoid a clone. I intend to use this method elsewhere in the future, that is why I am adding it.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/envelope-into_items
branch
from
7bad21d to
5e15229
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new method called
into_itemsto theEnvelopetype. This method is similar to the existingitemsmethod, except that it yields ownedEnvelopeItems rather than references.Also, refactor a test where we can use this new method to avoid a clone.
I intend to use this method elsewhere in the future, that is why I am adding it.