Annotate tests based on staff.ga-rollout status#107368
Merged
michelletran-sentry merged 2 commits intomasterfrom Feb 3, 2026
Merged
Annotate tests based on staff.ga-rollout status#107368michelletran-sentry merged 2 commits intomasterfrom
staff.ga-rollout status#107368michelletran-sentry merged 2 commits intomasterfrom
Conversation
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
326db5f to
0a9c38e
Compare
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
0a9c38e to
07be529
Compare
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
07be529 to
48561c4
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
48561c4 to
8ea54a4
Compare
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
8ea54a4 to
8dcc35a
Compare
cathteng
reviewed
Feb 2, 2026
Contributor
cathteng
left a comment
cathteng
left a comment
There was a problem hiding this comment.
Looks like we can get rid of a lot of tests! I was mostly looking for cases we would delete
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
8dcc35a to
6da0779
Compare
cathteng
approved these changes
Feb 2, 2026
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
6da0779 to
fddcdb6
Compare
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
fddcdb6 to
f6931ee
Compare
This is to prepare the option for removal
Add @override_options({"staff.ga-rollout": True/False}) decorators to
tests in tests/sentry/users/api/endpoints/ to ensure tests run with
appropriate feature flag configuration.
michelletran-sentry
force-pushed
the
test_tests_move_to_staff
branch
from
f6931ee to
7b2cba2
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| response = self.get_success_response(qs_params={"query": "is:superuser"}) | ||
| assert len(response.data) == 1 | ||
| assert response.data[0]["id"] == str(self.superuser.id) | ||
| assert len(response.data) == 0 |
Contributor
There was a problem hiding this comment.
Renamed test doesn't verify meaningful functionality
Medium Severity
The test test_staff_query was renamed from test_superuser_query but still queries is:superuser and now asserts 0 results. The original test verified the is:superuser query filter worked correctly by finding 1 superuser. The new test doesn't verify any query functionality - it just confirms that querying for non-existent users returns empty results, which provides no meaningful test coverage.
michelletran-sentry
added a commit
that referenced
this pull request
Feb 10, 2026
Similar to #107368, where I'm trying to convert and mark tests that depends on superusers who should be migrated to staff. This ensures all tests work with staff.ga-rollout=True while maintaining test coverage during the transition. Superuser tests in duplicate pairs can be easily identified and removed later. This is part of the effort to remove the staff.ga-rollout flag and migrate to staff-only mode. Changes: - Converted 5 superuser-only tests to staff in test_sentry_app_details.py: - test_staff_can_set_publish_request_inprogress_status - test_staff_delete_unpublished_app - test_staff_delete_unpublished_app_with_installs - test_staff_cannot_delete_published_app - test_staff_cannot_delete_partner_apps - Converted 1 superuser-only test to staff in test_sentry_apps_stats.py: - test_per_page - Updated DeleteSentryAppDetailsTest setUp to use staff user by default: - Creates staff user as org member in setUp - Logs in as staff instead of superuser - Simplifies individual test methods (no repeated membership creation) - Added decorators to ALL tests (47 total): - False decorator on superuser tests in duplicate pairs - True decorator on all other tests (staff and general tests) Co-authored-by: Claude <noreply@anthropic.com>
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
My attempt to clean up the feature flag resulted in a lot of changed files (#106966) . I'm opening up smaller PRs to migrate the tests more slowly. Then end goal is to change as many of the tests' functionality to use the staff flag (to preserve test coverage), then tag the tests that I can just delete in the migration (specific `superuser` tests). I'm starting with tests in the following directories: - `tests/sentry/relocation` - `tests/sentry/users/api` I'll probably have followups to do the tagging more slowly. ### Legal Boilerplate Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
jaydgoss
pushed a commit
that referenced
this pull request
Feb 12, 2026
Similar to #107368, where I'm trying to convert and mark tests that depends on superusers who should be migrated to staff. This ensures all tests work with staff.ga-rollout=True while maintaining test coverage during the transition. Superuser tests in duplicate pairs can be easily identified and removed later. This is part of the effort to remove the staff.ga-rollout flag and migrate to staff-only mode. Changes: - Converted 5 superuser-only tests to staff in test_sentry_app_details.py: - test_staff_can_set_publish_request_inprogress_status - test_staff_delete_unpublished_app - test_staff_delete_unpublished_app_with_installs - test_staff_cannot_delete_published_app - test_staff_cannot_delete_partner_apps - Converted 1 superuser-only test to staff in test_sentry_apps_stats.py: - test_per_page - Updated DeleteSentryAppDetailsTest setUp to use staff user by default: - Creates staff user as org member in setUp - Logs in as staff instead of superuser - Simplifies individual test methods (no repeated membership creation) - Added decorators to ALL tests (47 total): - False decorator on superuser tests in duplicate pairs - True decorator on all other tests (staff and general tests) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to clean up the feature flag resulted in a lot of changed files (#106966) . I'm opening up smaller PRs to migrate the tests more slowly. Then end goal is to change as many of the tests' functionality to use the staff flag (to preserve test coverage), then tag the tests that I can just delete in the migration (specific
superusertests).I'm starting with tests in the following directories:
tests/sentry/relocationtests/sentry/users/apiI'll probably have followups to do the tagging more slowly.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.