ref(perf-detectors): Pass detector-specific settings to PerformanceDetector constructors#107387
Merged
ref(perf-detectors): Pass detector-specific settings to PerformanceDetector constructors#107387
Conversation
…tector constructors
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
thetruecpaul
approved these changes
Feb 2, 2026
Contributor
thetruecpaul
left a comment
thetruecpaul
left a comment
There was a problem hiding this comment.
LGTM! Was this a problem that we'd seen in the wild? Or just preemptive improvement?
Member
Author
Not part of a real problem, just a bit of simplification of data model as we start working toward basing Performance Detectors on Workflow Engine Detectors. |
roggenkemper
added a commit
that referenced
this pull request
Feb 11, 2026
…` commands The `PerformanceDetector` constructor was refactored in #107387 to accept only the detector's own settings dict instead of the full settings dict. The `sentry performance detect` and `sentry performance timeit` CLI commands were not updated, causing them to pass the full settings dict and break. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, each PerformanceDetector received the full settings dict for all detector types and extracted its own config in
__init__. This meant every detector had visibility into other detectors' configuration, even though none actually used it.Now the caller extracts the specific detector's settings before instantiation, so each detector only receives its own config dict, and we can be confident configs are independent.