fix(tracemetrics): Open in explore for multi metrics opens each#110993
Open
narsaynorath wants to merge 1 commit intomasterfrom
Open
fix(tracemetrics): Open in explore for multi metrics opens each#110993narsaynorath wants to merge 1 commit intomasterfrom
narsaynorath wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
narsaynorath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each aggregate should be evaluated individually for the
metricparam because we're opening up to multi-metric support in Dashboards. This shouldn't change functionality because we should be actively storing the tracemetric in the aggregates already, this just makes it read each one to figure out what tracemetric to set instead of doing that reading upfront and propagating it through to every other aggregate assuming it's the same.