ref(api): mark previous enterprise endpoints as unowned#111002
Draft
ref(api): mark previous enterprise endpoints as unowned#111002
Conversation
github-actions
bot
added
the
Scope: Backend
| class ReleaseThresholdEndpoint(ProjectEndpoint): | ||
| permission_classes = (ProjectReleasePermission,) | ||
| owner: ApiOwner = ApiOwner.ENTERPRISE | ||
| owner: ApiOwner = ApiOwner.UNOWNED |
Member
There was a problem hiding this comment.
These are a lot of what rotational was doing. @mrduncan do you know who would take release tasks now?
Member
There was a problem hiding this comment.
@bruno-garcia releases are effectively unowned at the moment, right?
Member
sentaur-athena
left a comment
sentaur-athena
left a comment
There was a problem hiding this comment.
Moving them to unowned makes it harder to find them and add owners to them. Ideally we would not use the unowned tag ever.
Most of enterprise code will be owned by billing and product platform so I added Jason.
The only part that is not is related to releases, let's find the right owner.
| "POST": ApiPublishStatus.PRIVATE, | ||
| } | ||
| owner = ApiOwner.ENTERPRISE | ||
| owner = ApiOwner.UNOWNED |
Member
There was a problem hiding this comment.
@swartzrock my understanding is that some of these would be owned by product platform team. Maybe we should transfer them now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the enterprise team doesn't exist right now, these endpoints are all technically unowned.