feat(tracemetrics): Show all attributes in group by for multi metrics#111012
Open
narsaynorath wants to merge 2 commits intomasterfrom
Open
feat(tracemetrics): Show all attributes in group by for multi metrics#111012narsaynorath wants to merge 2 commits intomasterfrom
narsaynorath wants to merge 2 commits intomasterfrom
Conversation
static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Missing guard on
enabledwhen no metrics selected- Changed enabled from unconditional true to defined(traceMetrics[0]) to prevent unnecessary API calls when no metrics are selected.
Or push these changes by commenting:
@cursor push 5ca0908349
Preview (5ca0908349)
diff --git a/static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts b/static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
--- a/static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
+++ b/static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
@@ -47,7 +47,7 @@
return {
traceItemType: TraceItemDataset.TRACEMETRICS,
- enabled: true,
+ enabled: defined(traceMetrics[0]),
query:
!hasMultipleMetrics && traceMetrics[0]
? createTraceMetricFilter(traceMetrics[0])This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
static/app/views/dashboards/widgetBuilder/hooks/useWidgetBuilderTraceItemConfig.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


When there are multiple metrics selected, remove the attribute filter from the config where we define properties to use for the trace item attributes request.
Ideally we only fetch the ones that are relevant but I'm not entirely sure the backend supports OR requests properly yet, so we're going to go easy and just fetch everything.