feat(dashboards): text widget add to dashboard flow#111019
Draft
nikkikapadia wants to merge 8 commits intomasterfrom
Draft
feat(dashboards): text widget add to dashboard flow#111019nikkikapadia wants to merge 8 commits intomasterfrom
nikkikapadia wants to merge 8 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
nikkikapadia
commented
Mar 18, 2026
Comment on lines
483
to
+494
| eventView={eventViewFromWidget( | ||
| newWidgetTitle, | ||
| widget.queries[0]!, | ||
| widget.displayType === DisplayType.TEXT | ||
| ? { | ||
| name: '', | ||
| fields: [], | ||
| aggregates: [], | ||
| columns: [], | ||
| orderby: '', | ||
| conditions: '', | ||
| } | ||
| : widget.queries[0]!, |
Member
Author
There was a problem hiding this comment.
it's easier to do this than to create a different modal or even do an early return because the WidgetCard needs information from these providers otherwise it won't render. Also, we want to keep using the WidgetCard because it contains the WidgetFrame and the chart with all the appropriate formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the add to dashboard flow from text widgets is throwing errors. This PR fixes that. We can now add text widgets to other dashboards (if people want to ig)