Refactor has_release_permission to protect mutations#111021
Open
geoffg-sentry wants to merge 2 commits intomasterfrom
Open
Refactor has_release_permission to protect mutations#111021geoffg-sentry wants to merge 2 commits intomasterfrom
geoffg-sentry wants to merge 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing this three year old weakness 14a6b2c.
had_release permissionwas granting access if a user had any project on a release, which was nasty for mutations where a member shouldn't be able modify a release they don't have access to. We had a number of downstream code vulnerability fixes that stemmed from this, but I'm solving it upstream now.Changes:
has_release_permissionAddedrequire_all_projects_paramwith a false default so it's backward compatible with the previous fixes-- when true, checks against
request.access.has_projects_access()No changes to the read-only endpoints here nor artifactbundle assembly which we recently added explicit project scoping to.