Conversation
…idgets Add replay.id to SPECIAL_FIELDS so dot-notation replay IDs render as clickable links to the replay detail page. Update profile.id to link to the profile flamechart instead of rendering as plain text. Add project column to prebuilt Web Vitals tables so the profile renderer can resolve the project slug needed for the link. Refs DAIN-1292 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replay.idandprofile.idcolumns in dashboard table widgets rendered as plain text instead of clickable links. This was becauseSPECIAL_FIELDSinfieldRenderers.tsxonly had areplayId(camelCase) entry but noreplay.id(dot notation), and theprofile.identry rendered a shortened ID without a link.Since
getFieldRendererchecksSPECIAL_FIELDSfirst, fixing the renderers there makes them work everywhere (dashboards, discover, etc.) without needing to touch individual dataset configs.replay.identry toSPECIAL_FIELDSthat shares arenderReplayIdAsLinkhelper with the existingreplayIdentryprofile.identry to link to the profile flamechart page, with a plaintext fallback when the project slug can't be resolvedprojectcolumn to prebuilt Web Vitals sample tables (LCP, INP, CLS) so the profile renderer can resolve the project slug needed for the linkRefs DAIN-1292