Revert "feat(ACI): Make rule stats and group history endpoints backwards compatible (#110282)"#111038
Revert "feat(ACI): Make rule stats and group history endpoints backwards compatible (#110282)"#111038
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| except AlertRuleWorkflow.DoesNotExist: | ||
| # If no workflow is associated with this rule, just use the original behavior | ||
| logger.exception("No workflow associated with rule", extra={"rule_id": rule.id}) |
There was a problem hiding this comment.
logger.exception used for expected non-error code path
Medium Severity
logger.exception is used for an AlertRuleWorkflow.DoesNotExist case that the comment explicitly describes as expected behavior ("just use the original behavior"). logger.exception logs at ERROR level with a full stack trace, which in the Sentry codebase would generate error events in Sentry's own monitoring. For any rule without an associated workflow — likely very common during migration — this creates significant noise in production error tracking. logger.info or logger.warning would be more appropriate here.
Additional Locations (1)
saponifi3d
force-pushed
the
kcons/rollbax
branch
from
7b9075b to
6a47ea6
Compare
2 participants
This reverts commit e6be161.
The endpoint was already mostly backward compatible, so following our standard pattern results in a regression.