Skip to content

feat(taskbroker): Add Push Mode to Taskbroker #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
james-mcnulty wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat(taskbroker): Add Push Mode to Taskbroker #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1fb5dfa
Add Push Mode (Task Dispatchers and Pushers)
james-mcnulty Mar 16, 2026
a728613
Add Unit Tests, Flush Tasks on Shutdown
james-mcnulty Mar 17, 2026
6866ef2
Switch to Sentry Protos Release
james-mcnulty Mar 17, 2026
0a53d58
Replace Dispatcher w/Separate Fetch and Push Pools
james-mcnulty Mar 18, 2026
043559a
Initialize gRPC Server w/`0.0.0.0`
james-mcnulty Mar 18, 2026
f70cc3a
Add `PushPool` Unit Tests
james-mcnulty Mar 18, 2026
dafa06c
Add `FetchPool` Unit Tests
james-mcnulty Mar 18, 2026
e47a1e8
Fix Linting
james-mcnulty Mar 18, 2026
cb47f99
Address PR Comments (Fix Bugs, Make More Robust)
james-mcnulty Mar 18, 2026
aa055bc
Move Tasks Back to Pending on Push Failure, Add Server Unit Test for …
james-mcnulty Mar 18, 2026
2f540ad
Make Empty Store Backoff Configurable, Other Fixes and Tests
james-mcnulty Mar 18, 2026
97f00b0
Return Error from `fetch_activation` on Submit Failure
james-mcnulty Mar 18, 2026
6db46a0
Fix Fetch Unit Tests
james-mcnulty Mar 18, 2026
cf06e6b
Don't Use `FetchNextTask` When in Push Mode
james-mcnulty Mar 18, 2026
d28397d
Do Not Reset Task Status on Push Failure
james-mcnulty Mar 19, 2026
d42ffb5
Change Push Mode Config Name, Rename Helpers Module
james-mcnulty Mar 19, 2026
90825d4
Add Application and Namespace Filters to Config
james-mcnulty Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 48 additions & 27 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 6 additions & 5 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ clap = { version = "4.5.20", features = ["derive"] }
derive_builder = "0.20.2"
elegant-departure = { version = "0.3.1", features = ["tokio"] }
figment = { version = "0.10.19", features = ["env", "yaml", "test"] }
flume = "0.12.0"
futures = "0.3.31"
futures-util = "0.3.31"
hex = "0.4.3"
Expand All @@ -26,8 +27,8 @@ http-body-util = "0.1.2"
libsqlite3-sys = "0.30.1"
metrics = "0.24.0"
metrics-exporter-statsd = "0.9.0"
prost = "0.13"
prost-types = "0.13.3"
prost = "0.14"
prost-types = "0.14"
rand = "0.8.5"
rdkafka = { version = "0.37.0", features = ["cmake-build", "ssl"] }
sentry = { version = "0.41.0", default-features = false, features = [
Expand All @@ -41,16 +42,16 @@ sentry = { version = "0.41.0", default-features = false, features = [
"tracing",
"logs"
] }
sentry_protos = "0.4.11"
sentry_protos = "0.8.5"
serde = "1.0.214"
serde_yaml = "0.9.34"
sha2 = "0.10.8"
sqlx = { version = "0.8.3", features = ["sqlite", "runtime-tokio", "chrono", "postgres"] }
tokio = { version = "1.43.1", features = ["full"] }
tokio-stream = { version = "0.1.16", features = ["full"] }
tokio-util = "0.7.12"
tonic = "0.13"
tonic-health = "0.13"
tonic = "0.14"
tonic-health = "0.14"
tower = "0.5.1"
tracing = "0.1.40"
tracing-subscriber = { version = "0.3.18", features = [
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ The test suite is composed of unit and integration tests in Rust, and end-to-end

```bash
# Run unit/integration tests
make test
make unit-test
Copy link
Member

@evanh evanh Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Member Author

@james-mcnulty james-mcnulty Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's make unit-test, not make test - that doesn't do anything right now.

Copy link
Member Author

@james-mcnulty james-mcnulty Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather, there is no test target in the Makefile for doing both unit and integration tests, which seemed to be the intention here.


# Run end-to-end tests
make integration-test
Expand Down
Loading
Loading