feat(client) Make the ProducerFactory depend on a protocol#578
Merged
feat(client) Make the ProducerFactory depend on a protocol#578
Conversation
Using a concrete return type for ProducerFactory is blocking the adoption of a singleton producer in sentry. Refs getsentry/sentry#111191
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Incomplete protocol migration leaves registry using concrete type
- Updated TaskNamespace to use ProducerProtocol instead of KafkaProducer in _producers dict and _producer method return type, completing the protocol migration.
Or push these changes by commenting:
@cursor push e9348a2be7
Preview (e9348a2be7)
diff --git a/clients/python/src/taskbroker_client/registry.py b/clients/python/src/taskbroker_client/registry.py
--- a/clients/python/src/taskbroker_client/registry.py
+++ b/clients/python/src/taskbroker_client/registry.py
@@ -17,7 +17,7 @@
from taskbroker_client.retry import Retry
from taskbroker_client.router import TaskRouter
from taskbroker_client.task import ExternalTask, P, R, Task
-from taskbroker_client.types import ProducerFactory
+from taskbroker_client.types import ProducerFactory, ProducerProtocol
logger = logging.getLogger(__name__)
@@ -51,7 +51,7 @@
self.default_processing_deadline_duration = processing_deadline_duration # seconds
self.app_feature = app_feature or name
self._registered_tasks: dict[str, Task[Any, Any]] = {}
- self._producers: dict[str, KafkaProducer] = {}
+ self._producers: dict[str, ProducerProtocol] = {}
self._producer_factory = producer_factory
self.metrics = metrics
@@ -191,7 +191,7 @@
except Exception:
logger.exception("Failed to wait for delivery")
- def _producer(self, topic: str) -> KafkaProducer:
+ def _producer(self, topic: str) -> ProducerProtocol:
if topic not in self._producers:
self._producers[topic] = self._producer_factory(topic)
return self._producers[topic]This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
evanh
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Using a concrete return type for ProducerFactory is blocking the adoption of a singleton producer in sentry.
Refs getsentry/sentry#111191