Conversation
**Summary** - Initial package for Faugus Launcher
|
Hi, welcome to the Solus packages repo! For new packages, we require a Package Request (a particular type of issue) be submitted and accepted; see our Help Center page about this: https://help.getsol.us/docs/packaging/procedures/request-a-package#steps-to-request-a-new-package For now, I will convert your PRs to drafts. |
| @@ -0,0 +1,5 @@ | |||
| releases: | |||
| id: Faugus/faugus-launcher | |||
| type: github | |||
| It supports playing Windows games using Proton, Linux native games, prefix management, and Steam shortcut management. | ||
| builddeps : | ||
| - pkgconfig(gtk+-3.0) | ||
| - meson |
There was a problem hiding this comment.
You don't have to list meson in builddeps as it is already part of system.devel packages.
| install -d -m 0755 $installdir/usr/share/applications/ | ||
| cat > $installdir/usr/share/applications/faugus-launcher.desktop << EOF | ||
| [Desktop Entry] | ||
| Name=Faugus Launcher | ||
| GenericName=Game Launcher | ||
| Comment=Run Windows games using UMU-Launcher | ||
| Exec=faugus-launcher | ||
| Icon=faugus-launcher | ||
| Terminal=false | ||
| Type=Application | ||
| Categories=Game;Utility; | ||
| EOF |
There was a problem hiding this comment.
Faugus launcher include its own desktop file, why do you need to create one from scratch?
|
Please don't "resolve" the review before you actually address it. The point of pull request is that the maintainer can set certain standard of the code in the repository. People submitting pull request must adhere to that standard and must be willing to go through a review process. Please keep that in mind. |
Depends on #8002
Summary
Test Plan
eopkg.Checklist