Adjust role split string to not hardcode 'aws' partition of AWS#2042
Merged
felixfontein merged 1 commit intogetsops:mainfrom Feb 16, 2026
Merged
Adjust role split string to not hardcode 'aws' partition of AWS#2042felixfontein merged 1 commit intogetsops:mainfrom
felixfontein merged 1 commit intogetsops:mainfrom
Conversation
Closed
Contributor
Author
|
Ping @getsops/maintainers. |
Signed-off-by: Felix Fontein <felix@fontein.de>
Contributor
Author
|
@sabre1041 thanks for reviewing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also makes it possible to use AWS's new ECS (European Sovereign Cloud), which uses the partition
aws-euscaccording to https://aws.amazon.com/blogs/aws/opening-the-aws-european-sovereign-cloud/.Reference on ARNs: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference-arns.html
Fixes #805.
Closes #806.