Fix Users path for Gershwin

[pkgdemon]

Summary by Sourcery

Bug Fixes:

• Fix detection of the GhostBSD live user by checking the updated /Local/Users/ghostbsd home directory path instead of the old /Users/ghostbsd path.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the live GhostBSD user removal logic to use the correct home directory path for Gershwin systems.

Flow diagram for updated live user removal path check

flowchart TD
    A[Start remove_live_user] --> B{Check /usr/home/ghostbsd exists}
    B -->|yes| E[Echo Remove GhostBSD live user]
    B -->|no| C{Check /home/ghostbsd exists}
    C -->|yes| E
    C -->|no| D{Check /Local/Users/ghostbsd exists}
    D -->|yes| E
    D -->|no| F[Do nothing]
    E --> G[Run chroot command pw userdel -n ghostbsd -r]
    G --> H[End remove_live_user]
    F --> H

Loading

File-Level Changes

Change	Details	Files
Update the live GhostBSD user removal condition to check Gershwin-specific user home path.	Replace the macOS-style '/Users/ghostbsd' directory check with '/Local/Users/ghostbsd' in the removal guard condition Keep existing checks for '/usr/home/ghostbsd' and '/home/ghostbsd' unchanged to maintain compatibility across environments	backend/functions-users.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider extracting the list of possible ghostbsd home directories into a variable or helper to avoid duplicating hardcoded paths and make future platform-specific adjustments easier.
• Double-check whether the previous /Users/ghostbsd path is still needed for any environments; if both /Users/ghostbsd and /Local/Users/ghostbsd are valid in different cases, it may be safer to support both rather than replacing one with the other.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider extracting the list of possible ghostbsd home directories into a variable or helper to avoid duplicating hardcoded paths and make future platform-specific adjustments easier.
- Double-check whether the previous `/Users/ghostbsd` path is still needed for any environments; if both `/Users/ghostbsd` and `/Local/Users/ghostbsd` are valid in different cases, it may be safer to support both rather than replacing one with the other.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ericbsd]

LGTM