Skip to content

osx-clang: work around Homebrew's clang lacking REG_ENHANCED #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dscho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

osx-clang: work around Homebrew's clang lacking REG_ENHANCED #6138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions config.mak.uname
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,17 @@ ifeq ($(uname_S),Darwin)
NEEDS_GOOD_LIBICONV = UnfortunatelyYes
endif

# Homebrew's LLVM clang ships a regex.h that lacks REG_ENHANCED,
# which is needed for USE_ENHANCED_BASIC_REGULAR_EXPRESSIONS above.
# Use our bundled regex instead. This became a practical problem
# when Homebrew 5.1.0 started auto-linking versioned keg-only
# formulae (like llvm@15) into $(HOMEBREW_PREFIX)/bin/, causing
# CC=clang in CI to silently pick up Homebrew's clang instead of
# Apple's /usr/bin/clang.
ifeq ($(CC),clang)
NO_REGEX = HomebrewsClangUsesARegexThatLacksREG_ENHANCED
endif

# The builtin FSMonitor on MacOS builds upon Simple-IPC. Both require
# Unix domain sockets and PThreads.
ifndef NO_PTHREADS
Expand Down
Loading