Lite: native menus by OliverJAsh · Pull Request #13317 · gitbutlerapp/gitbutler

OliverJAsh · 2026-04-14T21:49:22Z

No description provided.

Copilot

Pull request overview

This PR switches “workspace” action/context menus in the Lite UI from Base UI’s in-DOM menus to Electron-native popup menus, wired through a new IPC endpoint.

Changes:

Replaced @base-ui/react Menu/ContextMenu usage in the workspace route with native-menu triggers and item definitions.
Added a renderer-side native menu helper (native-menu.ts) that serializes menu items and dispatches selection handlers.
Added an Electron IPC handler (lite:show-native-menu) plus preload/api typing to display a native Menu.popup() and return the selected item id.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
apps/lite/ui/src/routes/project/$id/workspace/route.tsx	Replaces Base UI menus with calls to `showNativeContextMenu` / `showNativeMenuFromTrigger` and inline `NativeMenuItem[]` definitions.
apps/lite/ui/src/routes/project/$id/workspace/route.module.css	Removes `:has(...aria-expanded="true")` styling hook that no longer applies with native menus.
apps/lite/ui/src/native-menu.ts	Adds renderer-side menu item serialization + IPC call to show a native menu and run the selected handler.
apps/lite/electron/src/preload.cts	Exposes `showNativeMenu` on `window.lite` via `ipcRenderer.invoke`.
apps/lite/electron/src/main.ts	Implements `lite:show-native-menu` handler using Electron `Menu.popup()` and a template builder.
apps/lite/electron/src/ipc.ts	Adds IPC types (`NativeMenuPopupItem`, `ShowNativeMenuParams`, etc.) and channel constant.

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Copilot · 2026-04-15T19:08:16Z

+			<button
+				type="button"
+				className={styles.itemRowAction}
+				aria-label={`${change.path} menu`}


This menu trigger is now a plain <button>; Menu.Trigger previously handled menu-related ARIA. Add aria-haspopup="menu" (and any other necessary ARIA attributes) so screen readers can identify this as opening a menu.

Suggested change

aria-label={`${change.path} menu`}

aria-label={`${change.path} menu`}

aria-haspopup="menu"

Copilot · 2026-04-15T19:08:17Z

+			<button
+				type="button"
+				className={styles.itemRowAction}
+				aria-label="Changes menu"


This button triggers a menu but lacks aria-haspopup="menu" now that it’s not using Menu.Trigger. Adding the appropriate ARIA attributes will prevent an accessibility regression for assistive technology users.

Suggested change

aria-label="Changes menu"

aria-label="Changes menu"

aria-haspopup="menu"

Copilot · 2026-04-15T19:08:17Z

+											<button
+												type="button"
+												className={styles.itemRowAction}
+												aria-label="Branch menu"


Since this button opens the branch menu via the native menu API, it should expose menu semantics (e.g., aria-haspopup="menu") that were previously supplied by Menu.Trigger to avoid an accessibility regression.

Suggested change

aria-label="Branch menu"

aria-label="Branch menu"

aria-haspopup="menu"

Copilot · 2026-04-15T19:08:18Z

+				<button
+					type="button"
+					className={styles.itemRowAction}
+					aria-label="Stack menu"


This stack menu trigger is now a plain button; Menu.Trigger previously provided menu-related ARIA attributes. Add aria-haspopup="menu" (and any other required ARIA attributes) so assistive technologies can recognize it as a menu trigger.

Suggested change

aria-label="Stack menu"

aria-label="Stack menu"

aria-haspopup="menu"

Copilot · 2026-04-15T19:08:18Z

+	const handlers = new Map<string, NativeMenuAction | undefined>();
+	const serializedItems = serializeNativeMenuItems(items, handlers, { value: 0 });
+


serializeNativeMenuItems expects a Map<string, NativeMenuAction | undefined>, but showNativeMenu constructs handlers as new Map<string, NativeMenuAction>() and passes it in. Because Map is invariant in its value type, this is a TypeScript type error (and it’s also inconsistent with handlers.set(itemId, item.onSelect) where onSelect can be undefined). Make handlers a Map<string, NativeMenuAction | undefined> (or only allocate itemId/store handlers for items that actually have an onSelect).

Copilot · 2026-04-15T19:08:18Z

@@ -0,0 +1,84 @@
+import type { NativeMenuPopupItem, NativeMenuPosition } from "#electron/ipc.ts";
+import { MouseEvent } from "react";


MouseEvent is only used as a type here. Prefer import type { MouseEvent } from "react"; to avoid introducing/keeping a runtime React import unnecessarily in this utility module (especially under isolatedModules/Vite transforms).

Suggested change

import { MouseEvent } from "react";

import type { MouseEvent } from "react";

Copilot · 2026-04-15T19:08:18Z

+							<button
+								type="button"
+								className={styles.itemRowAction}
+								aria-label="Commit menu"


This button opens a menu, but it no longer gets the ARIA semantics that Menu.Trigger previously provided. Consider adding aria-haspopup="menu" (and any other required ARIA attributes your a11y baseline expects) so assistive tech can announce it as a menu trigger.

Suggested change

aria-label="Commit menu"

aria-label="Commit menu"

aria-haspopup="menu"

Copilot AI review requested due to automatic review settings April 14, 2026 21:49

Copilot started reviewing on behalf of OliverJAsh April 14, 2026 21:49 View session

OliverJAsh force-pushed the push-nlvolzpnmtyk branch from 1170222 to 07875d2 Compare April 14, 2026 21:50

OliverJAsh force-pushed the push-pzxluozktuwo branch from a97b90b to 832c8ac Compare April 14, 2026 21:50

vercel bot temporarily deployed to Preview April 14, 2026 21:50 Inactive

Copilot AI reviewed Apr 14, 2026

View reviewed changes

Comment thread apps/lite/ui/src/native-menu.ts Outdated

Comment thread apps/lite/electron/src/main.ts

OliverJAsh force-pushed the push-pzxluozktuwo branch from 832c8ac to 8e6a011 Compare April 14, 2026 22:04

vercel bot temporarily deployed to Preview April 14, 2026 22:04 Inactive

OliverJAsh force-pushed the push-pzxluozktuwo branch from 8e6a011 to 7f2a5f6 Compare April 14, 2026 22:05

OliverJAsh force-pushed the push-nlvolzpnmtyk branch from 07875d2 to 149a006 Compare April 14, 2026 22:06

OliverJAsh force-pushed the push-pzxluozktuwo branch from 7f2a5f6 to 1dbb055 Compare April 14, 2026 22:06

vercel bot temporarily deployed to Preview April 14, 2026 22:06 Inactive

Base automatically changed from push-nlvolzpnmtyk to master April 15, 2026 10:22

Copilot AI review requested due to automatic review settings April 15, 2026 19:03

OliverJAsh force-pushed the push-pzxluozktuwo branch from 1dbb055 to 7d46870 Compare April 15, 2026 19:03

vercel bot temporarily deployed to Preview April 15, 2026 19:03 Inactive

Copilot started reviewing on behalf of OliverJAsh April 15, 2026 19:04 View session

Native context menus

a05a1dc

OliverJAsh enabled auto-merge April 15, 2026 19:05

OliverJAsh force-pushed the push-pzxluozktuwo branch from 7d46870 to a05a1dc Compare April 15, 2026 19:05

vercel bot temporarily deployed to Preview April 15, 2026 19:05 Inactive

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lite: native menus#13317

Lite: native menus#13317
OliverJAsh wants to merge 1 commit intomasterfrom
push-pzxluozktuwo

OliverJAsh commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	aria-label={`${change.path} menu`}
	aria-label={`${change.path} menu`}
	aria-haspopup="menu"

	aria-label="Changes menu"
	aria-label="Changes menu"
	aria-haspopup="menu"

	aria-label="Branch menu"
	aria-label="Branch menu"
	aria-haspopup="menu"

	aria-label="Stack menu"
	aria-label="Stack menu"
	aria-haspopup="menu"

		const handlers = new Map<string, NativeMenuAction \| undefined>();
		const serializedItems = serializeNativeMenuItems(items, handlers, { value: 0 });

		@@ -0,0 +1,84 @@
		import type { NativeMenuPopupItem, NativeMenuPosition } from "#electron/ipc.ts";
		import { MouseEvent } from "react";

	import { MouseEvent } from "react";
	import type { MouseEvent } from "react";

	aria-label="Commit menu"
	aria-label="Commit menu"
	aria-haspopup="menu"

Conversation

OliverJAsh commented Apr 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants