New build system using nix #1304
Check failed
There are 28 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🔴 | 5412a31 | build(nix): shell.nix and devenv support | Sign-off not found |
| 🔴 | 248ef29 | build(nix): phase out rust-toolchain.toml | Sign-off not found |
| 🔴 | e5c590e | build(nix): frr build | Sign-off not found |
| 🔴 | 787f154 | build(nix): clean up dpdk build | Sign-off not found |
| 🔴 | 5b03a0b | fix(build): wrong bluefield2 platform | Sign-off not found |
| 🔴 | ae8122d | build(nix): add minimal gdb build | Sign-off not found |
| 🔴 | 8537021 | build(nix): update nix profiles | Sign-off not found |
| 🔴 | 8b294ed | build(nix): rework default.nix | Sign-off not found |
| 🔴 | 4755d68 | build: rework build.rs scripts | Sign-off not found |
| 🔴 | 6d448c1 | build: simplify build environment | Sign-off not found |
| 🔴 | cbf1d14 | ci: rewrite GitHub workflows for nix-based builds | Sign-off not found |
| 🔴 | 88dfcbe | fix(build): incorrect tokio features in dev-depend... | Sign-off not found |
| 🔴 | 47431f0 | test: update tests for nix build system | Sign-off not found |
| 🟢 | d56f4e1 | chore: bump dependencies | Valid sign-off found |
| 🔴 | 1b1c52a | chore(docs): bump KaTeX and clean up doc includes | Sign-off not found |
| 🔴 | 419f7a5 | chore(scripts): Remove rust.env | Sign-off not found |
| 🔴 | d487846 | chore(build): rewrite justfile for nix build syste... | Sign-off not found |
| 🔴 | 23936bf | chore(docs): update documentation for nix build sy... | Sign-off not found |
| 🔴 | 4144d8c | chore(build): add setup-roots target to justfile | Sign-off not found |
| 🟢 | 5020394 | chore(ci): make sanitizer builds optional | Valid sign-off found |
| 🟢 | 9b0f245 | fix: Fix generated file oversight | Valid sign-off found |
| 🟢 | d2cbc95 | fix: Comment out failing new workflows | Valid sign-off found |
| 🟢 | 29f59f0 | chore(scripts): Remove unneeded scripts | Valid sign-off found |
| 🔴 | efb185c | chore(deps): add FRR component pins | Sign-off not found |
| 🔴 | b0f7d4a | chore(deps): update pinned dependencies | Sign-off not found |
| 🔴 | c5ab49f | chore(nix): trim unnecessary outputs and inputs fr... | Sign-off not found |
| 🔴 | 49b1bcb | chore(nix): add FRR component nix packages | Sign-off not found |
| 🔴 | 90420e1 | chore(nix): rework FRR overlay and build for conta... | Sign-off not found |
| 🔴 | fc8846d | chore(nix): rework default.nix build definitions a... | Sign-off not found |
| 🔴 | cfb8cd5 | chore(build): use VERSION env var for gateway vers... | Sign-off not found |
| 🔴 | d958348 | chore(ci): update dev.yml for nix build system | Sign-off not found |
| 🔴 | a169f5f | chore(scripts): add vlab development scripts | Sign-off not found |
| 🔴 | cd18b19 | chore(build): rework justfile for multi-target bui... | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Remediation commits are not allowed for this repository. For more details about how to enable them, please see the documentation.
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~33 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin pr/mvachhar/new-build-system