Conversation
qmonnet
force-pushed
the
pr/qmonnet/auto-bump
branch
7 times, most recently
from
84cba9f to
4ea5c0c
Compare
We had "just bump_minor_version" to automatically bump the minor version of the project in the Cargo.toml file; add a new just recipe to update the version to any specified value, "just bump_version <version>" (and make the existing recipe rely on it to avoid duplication). The objective is to have a more flexible command to bump the version if, for example, we want to tag a patch version. Additionally, accept an optional yq_flags argument for "just bump_minor_version". This is because not all versions of yq work the same, and some need to be told explicitly that we feed them TOML as input. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/qmonnet/auto-bump
branch
2 times, most recently
from
7e238ee to
042c946
Compare
qmonnet
requested review from
Frostman and
Copilot
and removed request for
Fredi-raspall
|
@Frostman This is so that you, or someone else, can easily open a PR to bump the version in dataplane if you need to. Not that it should be you doing it, it's more in case you need it at some point (and should also make it faster for me to do it). The workflow bumps the minor version number by default, or uses the number passed as a dispatch argument. |
There was a problem hiding this comment.
Pull request overview
Adds a manually triggered GitHub Actions workflow to bump the repository’s workspace version in Cargo.toml, intended to let contributors update the dataplane version without setting up a local Rust build environment.
Changes:
- Refactors
just bump_minor_versionand introducesjust bump_version <x.y.z>for updating the workspace version. - Adds a
workflow_dispatch-only workflow that bumps the version and opens a PR with the result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
justfile |
Adds a parameterized version bump recipe and refactors minor bump to call it. |
.github/workflows/version-bump.yml |
New manual workflow to bump Cargo workspace version and open a PR. |
You can also share your feedback on Copilot code review. Take the survey.
qmonnet
force-pushed
the
pr/qmonnet/auto-bump
branch
5 times, most recently
from
a48f07c to
bbbd163
Compare
There was a problem hiding this comment.
Pull request overview
Adds a manually-triggered GitHub Actions workflow to bump the workspace version in Cargo.toml (and update the workspace lockfile), so maintainers/contributors can generate a version-bump PR without setting up the local build tooling.
Changes:
- Refactors
just bump_minor_versionto delegate to a newjust bump_version <x.y.z>recipe. - Adds
.github/workflows/version-bump.yml(workflow_dispatch) to bump the version and open a PR using a GitHub App token.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
justfile |
Adds a parameterized bump_version recipe and updates bump_minor_version to reuse it. |
.github/workflows/version-bump.yml |
New manually-dispatched workflow that bumps Cargo workspace version, commits, and opens a PR. |
You can also share your feedback on Copilot code review. Take the survey.
This new workflow runs only on manual dispatch. The objective is to provide a way for contributors who don't have a Rust and compile environment set up to simply bump the version in the Cargo.toml file. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/qmonnet/auto-bump
branch
from
bbbd163 to
f70df64
Compare
|
New workflow that doesn't touch anything interesting, only works on manual dispatches, and doesn't introduce anything that looks sensitive (that would differ from existing workflows) as far as I can tell. I'll go ahead and merge it to test it to cut a new release for dataplane. |
This new workflow runs only on manual dispatch. The objective is to provide a way for contributors who don't have a Rust and compile environment set up to simply bump the version in the Cargo.toml file.