Merged
Conversation
Fredi-raspall
force-pushed
the
pr/fredi/no-bg-readvertise
branch
2 times, most recently
from
c7b00ce to
900e59c
Compare
sergeymatov
requested changes
Mar 17, 2026
| } | ||
|
|
||
| const EVPN_RMAP_IN: &str = "EVPN-ROUTE-MAP-IN"; | ||
| fn route_map_evpn_in() -> RouteMap { |
Contributor
There was a problem hiding this comment.
I think we will widely use RouteMap filtering later. From the code there is no particular sign of what kind of RouteMap we are creating despite of NoAdvertise use in this function. Maybe we can either rename this particular function into route_map_evpn_in_no_adv() or have a constructor function that receives set of RouteMapEntries and applies it?
Fredi-raspall
force-pushed
the
pr/fredi/no-bg-readvertise
branch
from
900e59c to
5c47698
Compare
sergeymatov
approved these changes
Mar 17, 2026
Contributor
sergeymatov
left a comment
sergeymatov
left a comment
There was a problem hiding this comment.
Thanks @Fredi-raspall !
Define a new type to extend the configuration of a bgp neighbor on a per addrss family basis, and extend renderer to configure it. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Configure bgp so that no routes get re-advertised. This prevents the gateway from advertising any route it learns from other peers. A gateway should not re-advertise the routes it learns but only those it originates, in the current design.This prevents it from announcing evpn routes that it learns (like type 2) which it should not advertise. This behavior is achieved by marking all of the evpn routes learnt with community "no-advertise". Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/no-bg-readvertise
branch
from
5c47698 to
2d90fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't let gateway re-advertise routes
Fixes: #1266