feat(publishOnEventBridge): add persistent keys in logs#5030
Open
edersonbrilhante wants to merge 1 commit intogithub-aws-runners:mainfrom
Open
feat(publishOnEventBridge): add persistent keys in logs#5030edersonbrilhante wants to merge 1 commit intogithub-aws-runners:mainfrom
edersonbrilhante wants to merge 1 commit intogithub-aws-runners:mainfrom
Conversation
edersonbrilhante
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update
publishOnEventBridgeto use the existingreadEventhelper instead of directly reading thex-github-eventheader and callingcheckEventIsSupported.Only
eventTypeis destructured fromreadEvent, since the parsed event object isn’t needed.Why
This makes the EventBridge path consistent with
publishForRunners, ensuring persistent logging fields (repository, action, workflow job name, status, etc.) are added to the logger in both code paths.Impact