C#: Update to .NET SDK 9.0.300 and .NET Runtime 9.0.5.#20352
C#: Update to .NET SDK 9.0.300 and .NET Runtime 9.0.5.#20352michaelnebel merged 5 commits intogithub:mainfrom
Conversation
f332ec3 to
bf032af
Compare
1cfa066 to
38cdd22
Compare
4079db7 to
9a97fb0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C# extractor to use .NET SDK 9.0.300 (and .NET Runtime 9.0.5) for improved stability on action runners with .NET Runtime 9.0.8 installed.
Key changes:
- Updates the C# extractor to use .NET SDK 9.0.300 and Runtime 9.0.5
- Updates most integration tests to use .NET SDK 9.0.304
- Adds file filtering functionality to avoid packaging issues with localized files
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/csharp.bzl | Adds file filtering rule and updates binary packaging logic |
| csharp/scripts/stubs/helpers.py | Updates SDK version from 9.0.100 to 9.0.300 |
| csharp/scripts/create-extractor-pack.sh | Updates runtime version from 9.0.0 to 9.0.5 |
| Various global.json files | Updates SDK versions to 9.0.304 for integration tests |
| Various .expected files | Updates assembly references to reflect new .NET versions |
f9b38d4 to
6a2c959
Compare
A `publish` directory for a C# binary contains copies of some DLLs inside localized subdirectories (e.g. `ru`). We want to ignore those, as otherwise our packaging machinery now goes haywire, with the newer version of `rules_csharp`. In any case we never shipped those.
6a2c959 to
a0f8b58
Compare
| @@ -0,0 +1,57 @@ | |||
| "rules_dotnet" | |||
There was a problem hiding this comment.
Is this a patched version of rules_dotnet?
There was a problem hiding this comment.
It is my understanding that in this file we create version 0.19.2-codeql.1 of rules_dotnet, where source.json specifies that we should apply the patch in misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/patches/revert_additional_files_in_nuget_archive.patch. However, I don't have any real understanding of the Bazel eco system (cc. @redsun82 ).
In this PR we update
rules_dotnet0.19.2.We hope that this will make test execution and extraction "more stable" on actions runners with .NET Runtime 9.0.8 installed.