Conversation
redsun82
added
the
depends on internal PR
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades rules_rust in the Bazel build system, along with updating several related modules to avoid warnings. The upgrade fixes a broken vendor check by changing how rules_rust discovers Cargo.toml files - the new version only searches for files reachable from the root workspace, avoiding problematic test files.
Key Changes:
- Upgraded
rules_rustto a newer version - Updated related modules to eliminate warnings
- Fixed vendor check behavior through improved workspace file discovery
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
CI failures are expected at this stage, an internal PR needs to merged first. |
esbena
reviewed
Oct 23, 2025
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
enlighten me: where does the now-unlisted Cargo.toml files get picked up now then?
esbena
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated some other modules that give off warnings otherwise.
This fixes the broken vendor check, because new
rules_rustnow does not go and look for allCargo.toml, but only those reachable from the root workspace (which also makes for a leaner vendor target definition). This means the vendoring script won't look at the brokenCargo.tomlfile we have in the QL tests any more.